Unify criteria for automatically adding cache invalidation token when including static resources #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unified the criteria used in Java standard classes for adding a cache invalidation token for cache busting of static resources
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
claudiamurialdo
approved these changes
Nov 9, 2020
Collaborator
This was referenced Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified the criteria for adding a cache invalidation token for cache busting of static resources, with the criteria used in Java standard classes.
This was an issue with the JavaScript render file of User Controls, because in DotNet no token was added when including the resource (see related issue).
Changes proposed in this Pull Request
GetURLBuildNumbermethod that returns a cache invalidation token when none was provided (except when the URI is absolute)GetCacheInvalidationTokenmethod toGxContextso we can re-use it fromGetURLBuildNumber.GetURLBuildNumberin methods that include stylesheets and JavaScript files, following the same criteria as in Java (see Java standard classes AddStyleSheetFile and AddJavaScriptSource methods).Issue:84288