-
Notifications
You must be signed in to change notification settings - Fork 12
Major improvements to External Storage Support #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abs/DotNetClasses into storage-private-support
# Conflicts: # dotnet/test/DotNetUnitTest/DotNetUnitTest.csproj
…abs/DotNetClasses into storage-private-support # Conflicts: # dotnet/test/DotNetUnitTest/DotNetUnitTest.csproj
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
… on Google Cloud Storage
…abs/DotNetClasses into storage-private-support
Collaborator
Manual cherry pick to beta success |
claudiamurialdo
previously approved these changes
Jul 2, 2021
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
Collaborator
Manual cherry pick to beta success |
iroqueta
approved these changes
Jul 8, 2021
jechague
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to GeneXus External Storage implementation.
(#249 and #283 and #314. All these PR are within this PR)
New
Improvements
New Property Name syntax
Provider Property Names were confusing, duplicate between providers so could not be set by ENV VARIABLES.
Now Properties follows the syntax: "STORAGE_%ProviderName%_%PropertyName%". (For compatibility reasons, old Properties name still supported).
In the future, we could support multiples providers as:
STORAGE_AWSS3_MyCustomProv_%PropertyName%Examples (old property names)
These properties are now:
How to run Unit Tests
** For security reasons, Secret Key has been removed from PR.
S3
AZURE
MINIO
Google Cloud Storage