Skip to content

Types not intended to be used outside are changed from public to internal #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 22, 2022
Merged

Types not intended to be used outside are changed from public to internal #624

merged 7 commits into from
Jul 22, 2022

Conversation

@claudiamurialdo
Copy link
Collaborator

@claudiamurialdo claudiamurialdo commented Jun 30, 2022

No description provided.

@genexusbot
Copy link
Collaborator

genexusbot commented Jun 30, 2022

Cherry pick to beta failed, 1 conflicted file in commit 146f6e3
  • dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests June 30, 2022 22:22 Inactive
@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jun 30, 2022
@genexusbot
Copy link
Collaborator

genexusbot commented Jun 30, 2022

Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jun 30, 2022
@sjuarezgx
Revert "Types that are not intended to be used outside of standard cl…
cd96d32 
…asses are changed from public to internal"

This reverts commit 146f6e3.
@sjuarezgx sjuarezgx temporarily deployed to external-storage-tests July 7, 2022 11:57 Inactive
@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta failed, 1 conflicted file in commit cd96d32
  • dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jul 7, 2022
@anaiberta
Restore "internal" definition for Types that are not intended to be u…
f5da7c6 
…sed outside of standard classes are changed from public to internal""

This partially reverts commit cd96d32.
@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Manual revert to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta failed, 1 conflicted file in commit 146f6e3
  • dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta failed, 1 conflicted file in commit 146f6e3
  • dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jul 7, 2022
@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 7, 2022

Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 22, 2022 15:37 Inactive
@claudiamurialdo claudiamurialdo merged commit c38c19e into master Jul 22, 2022
@claudiamurialdo claudiamurialdo deleted the public-to-internal branch July 22, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlejandroP AlejandroP Awaiting requested review from AlejandroP

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@claudiamurialdo @genexusbot @sjuarezgx @anaiberta