Skip to content

Types not intended to be used outside are changed from public to internal #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Types not intended to be used outside are changed from public to internal #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
146f6e3
Types that are not intended to be used outside of standard classes ar…
claudiamurialdo Jun 30, 2022
cd96d32
Revert "Types that are not intended to be used outside of standard cl…
sjuarezgx Jul 7, 2022
f5da7c6
Restore "internal" definition for Types that are not intended to be u…
anaiberta Jul 7, 2022
e918568
HttpTriggerHandler is public so, it requires IGXRouting be public too.
anaiberta Jul 7, 2022
d458b9f
Redefine GxRestWrapper as public to avoid build error by now.
anaiberta Jul 7, 2022
01f51a0
Redefine GxRestWrapper as public to avoid build error by now.
anaiberta Jul 7, 2022
b681880
Merge branch 'master' into public-to-internal
claudiamurialdo Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/dotnetcore/GxClasses.Web/Middleware/GXBCRestService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace GeneXus.Application
{
public class GXBCRestService :GxRestWrapper
internal class GXBCRestService :GxRestWrapper
{
GxSilentTrnSdt _worker;
private const string INSERT_OR_UPDATE_PARAMETER = "insertorupdate";
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/dotnetcore/GxClasses.Web/Middleware/GXRouting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace GxClasses.Web.Middleware
{
public class GXRouting : IGXRouting
internal class GXRouting : IGXRouting
{

static readonly ILog log = log4net.LogManager.GetLogger(typeof(IGXRouting));
Expand Down
4 changes: 3 additions & 1 deletion dotnet/src/dotnetcore/GxClasses.Web/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@


[assembly: InternalsVisibleTo("DotNetCoreUnitTest")]
[assembly: InternalsVisibleTo("GxNetCoreStartup")]
[assembly: InternalsVisibleTo("GxNetCoreStartup")]
[assembly: InternalsVisibleTo("GeneXus.Deploy.AzureFunctions.Handlers")]
[assembly: InternalsVisibleTo("AzureFunctionsTest")]
2 changes: 2 additions & 0 deletions dotnet/src/dotnetcore/GxClasses/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@
[assembly: InternalsVisibleTo("GxClasses.Web")]
[assembly: InternalsVisibleTo("GxSearch")]
[assembly: InternalsVisibleTo("GxNetCoreStartup")]
[assembly: InternalsVisibleTo("GeneXus.Deploy.AzureFunctions.Handlers")]
[assembly: InternalsVisibleTo("AzureFunctionsTest")]
[assembly: InternalsVisibleTo("GXQueue")]