Skip to content

Fix Fortify security scanning #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iroqueta merged 2 commits into from
Dec 16, 2025
Merged

Fix Fortify security scanning #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed336d
Fix Fortify security scanning
iroqueta Dec 5, 2025
7932d53
Remove GX Jar ClassLoader that has security issues and is not used.
iroqueta Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions android/src/main/java/com/genexus/db/Namespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ public class Namespace extends AbstractNamespace
public static final int GXDB_CLIENT = 0;
public static final int GXDB_SERVER = 1;
private static Hashtable namespaceList = new Hashtable();

private GXJarClassLoader classLoader;

private Hashtable dataSources = new Hashtable();
private String name;

Expand Down Expand Up @@ -233,27 +230,6 @@ public static Namespace getNamespace(String name)

public void reset()
{
if (classLoader != null)
{
classLoader = null;
/* try
{
classLoader.resetClassLoader();
}
catch (java.io.IOException e)
{
System.err.println("Error resetting namespace classloader " + e.getMessage());
}
*/
}
}

public synchronized GXJarClassLoader getClassLoader()
{
if(classLoader == null)
classLoader = new GXJarClassLoader(classesArchive, autoReload);
else classLoader = classLoader.getClassLoaderInstance();
return classLoader;
}

public int getDataSourceCount()
Expand Down
235 changes: 0 additions & 235 deletions common/src/main/java/com/genexus/GXJarClassLoader.java
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions gxcompress/src/main/java/com/genexus/compression/GXCompressor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,9 @@ private static void decompressZip(File archive, String directory) throws IOExcep
ZipEntry zipEntry;
while ((zipEntry = zis.getNextEntry()) != null) {
File newFile = new File(directory, zipEntry.getName());
if (HasZipSlipVulnerability(newFile, directory)) {
throw new IOException("Bad tar entry: " + zipEntry.getName());
}
if (zipEntry.isDirectory()) {
if (!newFile.isDirectory() && !newFile.mkdirs()) {
throw new IOException("Failed to create directory " + newFile);
Expand All @@ -614,6 +617,9 @@ private static void decompress7z(File archive, String directory) throws IOExcept
SevenZArchiveEntry entry;
while ((entry = sevenZFile.getNextEntry()) != null) {
File newFile = new File(directory, entry.getName());
if (HasZipSlipVulnerability(newFile, directory)) {
throw new IOException("Bad tar entry: " + entry.getName());
}
if (entry.isDirectory()) {
if (!newFile.isDirectory() && !newFile.mkdirs()) {
throw new IOException("Failed to create directory " + newFile);
Expand All @@ -640,6 +646,9 @@ private static void decompressTar(File archive, String directory) throws IOExcep
TarArchiveEntry entry;
while ((entry = tis.getNextEntry()) != null) {
File newFile = new File(directory, entry.getName());
if (HasZipSlipVulnerability(newFile, directory)) {
throw new IOException("Bad tar entry: " + entry.getName());
}
if (entry.isDirectory()) {
if (!newFile.isDirectory() && !newFile.mkdirs()) {
throw new IOException("Failed to create directory " + newFile);
Expand Down Expand Up @@ -787,4 +796,12 @@ private static void decompressJar(File archive, String directory) throws IOExcep
}
}
}

// Check for Zip Slip vulnerability: ensure extracted file remains within target directory
// Use Path.normalize() and Path.startsWith()
private static boolean HasZipSlipVulnerability(File file, String directory) {
java.nio.file.Path destDirPath = new File(directory).toPath().toAbsolutePath().normalize();
java.nio.file.Path newFilePath = file.toPath().toAbsolutePath().normalize();
return !newFilePath.startsWith(destDirPath);
}
}
23 changes: 0 additions & 23 deletions java/src/main/java/com/genexus/db/Namespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ public class Namespace extends AbstractNamespace
public static final int GXDB_SERVER = 1;
private static ConcurrentHashMap<String, String> namespaceListCheck = new ConcurrentHashMap<String, String>();
private static ConcurrentHashMap<String, Namespace> namespaceList = new ConcurrentHashMap<String, Namespace>();

private GXJarClassLoader classLoader;
private ConcurrentHashMap<String, DataSource> dataSources = new ConcurrentHashMap<String, DataSource>();

private String name;
Expand Down Expand Up @@ -257,19 +255,6 @@ public static Namespace getNamespace(String name)

public void reset()
{
if (classLoader != null)
{
classLoader = null;
/* try
{
classLoader.resetClassLoader();
}
catch (java.io.IOException e)
{
System.err.println("Error resetting namespace classloader " + e.getMessage());
}
*/
}
for (Enumeration<UserInformation> en = DBConnectionManager.getInstance().getServerConnections(); en.hasMoreElements();)
{
ServerUserInformation user = (ServerUserInformation) en.nextElement();
Expand All @@ -280,14 +265,6 @@ public void reset()
}
}

public synchronized GXJarClassLoader getClassLoader()
{
if(classLoader == null)
classLoader = new GXJarClassLoader(classesArchive, autoReload);
else classLoader = classLoader.getClassLoaderInstance();
return classLoader;
}

public int getDataSourceCount()
{
return dataSources.size();
Expand Down
Loading