Skip to content

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Oct 15, 2020

Issue: 85633

Every Http Upload via 'gxObject' endpoint, would leak the ModelContext static ThreadLocal variable.
In that case, if the Tomcat Thread was reused by the Pool for other Request, the ModelContext would point to an invalid old reference.

Best case scenario, an exception was thrown. But maybe in other cases, it would behave incorrectly.

Caused by: java.lang.NullPointerException
at org.apache.catalina.connector.Response.generateCookieString(Response.java:981) ~[catalina.jar:8.5.47]
at org.apache.catalina.connector.Response.addCookie(Response.java:929) ~[catalina.jar:8.5.47]
at org.apache.catalina.connector.ResponseFacade.addCookie(ResponseFacade.java:386) ~[catalina.jar:8.5.47]
at javax.servlet.http.HttpServletResponseWrapper.addCookie(HttpServletResponseWrapper.java:58) ~[servlet-api.jar:?]
at com.genexus.webpanels.HttpContextWeb.setCookieRaw(HttpContextWeb.java:867) ~[gxclassR.jar:?]
at com.genexus.webpanels.HttpContextWeb.setCookieRaw(HttpContextWeb.java:841) ~[gxclassR.jar:?]
at com.genexus.webpanels.HttpContextWeb.setCookie(HttpContextWeb.java:880) ~[gxclassR.jar:?]
at com.genexus.internet.HttpContext.initClientId(HttpContext.java:880) ~[gxclassR.jar:?]
at com.genexus.GXProcedure.<init>(GXProcedure.java:111) ~[gxclassR.jar:?]
at com.genexus.GXProcedure.<init>(GXProcedure.java:36) ~[gxclassR.jar:?]

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta October 15, 2020 18:26
@ggallotti ggallotti merged commit e5324f2 into master Oct 16, 2020
@ggallotti ggallotti deleted the clean-modelcontext-afterupload branch October 16, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants