Basic auth changed to raw auth header #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
iroqueta
reviewed
Sep 28, 2021
Collaborator
iroqueta
left a comment
iroqueta
left a comment
There was a problem hiding this comment.
It seems that we have duplicate code, try to unify it
Collaborator
Cherry pick to beta success |
iroqueta
previously approved these changes
Sep 28, 2021
Collaborator
Cherry pick to beta success |
iroqueta
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, basic auth using httpclient lib is not behaving as the old implementation (which is the spected and seems to be the correct one).