fix: resolve 111 clippy warnings across 45 files#200
Merged
Conversation
Reduce clippy warnings from 224 to 113 (50% reduction) with zero test regressions. Categories fixed: map_or→is_some_and (23), useless conversions (14), immediately dereferenced refs (12), iterate map keys/values (12), redundant closures (8), clone on Copy types (6), or_insert_with→or_default (4), assert_eq!(bool)→assert! (4), unreachable patterns (3), unused mut/vars, box simplifications, and collapsed if-else chains. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Addresses high-severity DoS vulnerability in quinn-proto 0.11.13. Dependency chain: clickgraph-client → reqwest → quinn → quinn-proto. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
genezhang
force-pushed
the
fix/clippy-warnings-cleanup
branch
from
67b9419 to
7db12ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map_or→is_some_and(23), useless conversions (14), deref refs (12), map iteration (12), redundant closures (8), clone-on-Copy (6),or_default(4),assert!(4), unreachable patterns (3), unused mut/vars, box simplificationsTest plan
cargo clippy --all-targets— 113 warnings (down from 224)cargo test— 1,575 tests pass, 0 failurescargo fmt --all— clean🤖 Generated with Claude Code