UI overhaul Phase 4: shared overlays (palette, review, context menu, delete, theme popover, help)#19
Merged
Merged
Conversation
Command palette: Sessions/Commands sections + blurred scrim header. Help: two-column keyboard grid. Context menu: brief's item order with Kill (stop, keep — yellow) and Delete (remove — red) as distinct actions. New styled delete-confirm dialog routed through the existing optimistic-removal path. Code review: mauve staged-comment bubbles (you/staged) + 'Apply (n) →' count that closes the overlay on success. Theme picker: top-right anchored popover listing all themes with an active check + follow-system toggle and live preview (active check always shown; per-appearance command seeds a concrete theme). Frontend only; semantic tokens; scrim via color-mix + backdrop blur; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Aligns page objects and scenarios with the new DOM/behavior introduced across the overhaul: sidebar liveness dots + comment/blocked chips + GROUP BY segmented control (Phase 2, #17); theme all-themes popover with .theme-modal-check + follow-system row (Phase 4); review 'Apply (n) →' label and close-on-apply (Phase 4). Test maintenance only (no behavioral weakening). npm test 49/49 and npm run test-iwft 51/51 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #18 (Phase 3). Do not merge yet. Base is
ui-overhaul-p3-center.Reworks the shared overlays. Built via recon → 4 sequential single-writer sub-steps → parallel verify, then a test-maintenance pass.
What's here (overlay code)
Sessions+Commandssections, blurred scrim,⌘/placeholder/escheader. Provider model + fuzzy score preserved.⌦, mono session name, branch-deletion warning; confirming routes through the existing optimistic removal (vanishes from Console and Board, counts recount, active tab advances).you/stagedbubbles;Apply (n) →reflects the staged count and closes the overlay on success (returns to the workspace).✓+ follow-system toggle and live preview.Small brief-sanctioned tweak: the active check always marks the resolved theme (even in system mode), and a per-appearance command seeds a concrete highlight.
Test maintenance (second commit)
Updated page objects + iwft scenarios to the new DOM/behavior. Note: 3 of these (sidebar grouping control, liveness dots, comment/blocked chips) trace to Phase 2 (#17) — that PR's sidebar redesign changed the DOM and the iwft suite wasn't re-run there; they're fixed here so the stack tip is green. The rest are Phase 4 (theme popover, review label/close).
Verification
npm run typecheckclean ·npm test49/49 ·npm run test-iwft51/51.🤖 Generated with Claude Code