Skip to content

UI overhaul Phase 4: shared overlays (palette, review, context menu, delete, theme popover, help)#19

Merged
Ed-Barnes937 merged 2 commits into
mainfrom
ui-overhaul-p4-overlays
Jun 24, 2026
Merged

UI overhaul Phase 4: shared overlays (palette, review, context menu, delete, theme popover, help)#19
Ed-Barnes937 merged 2 commits into
mainfrom
ui-overhaul-p4-overlays

Conversation

@Ed-Barnes937

Copy link
Copy Markdown
Collaborator

Stacked on #18 (Phase 3). Do not merge yet. Base is ui-overhaul-p3-center.

Reworks the shared overlays. Built via recon → 4 sequential single-writer sub-steps → parallel verify, then a test-maintenance pass.

What's here (overlay code)

  • Command paletteSessions + Commands sections, blurred scrim, /placeholder/esc header. Provider model + fuzzy score preserved.
  • Help — two-column keyboard grid (no keybinding changes).
  • Context menu — brief's order; Kill — stop process (yellow, keeps the session) and Delete session… (red, removes it) are now distinct actions.
  • Delete-confirm dialog — red , mono session name, branch-deletion warning; confirming routes through the existing optimistic removal (vanishes from Console and Board, counts recount, active tab advances).
  • Code review — staged comments render as mauve you/staged bubbles; Apply (n) → reflects the staged count and closes the overlay on success (returns to the workspace).
  • Theme picker — top-right anchored popover listing all themes with an active + follow-system toggle and live preview.

Small brief-sanctioned tweak: the active check always marks the resolved theme (even in system mode), and a per-appearance command seeds a concrete highlight.

Test maintenance (second commit)

Updated page objects + iwft scenarios to the new DOM/behavior. Note: 3 of these (sidebar grouping control, liveness dots, comment/blocked chips) trace to Phase 2 (#17) — that PR's sidebar redesign changed the DOM and the iwft suite wasn't re-run there; they're fixed here so the stack tip is green. The rest are Phase 4 (theme popover, review label/close).

Verification

  • npm run typecheck clean · npm test 49/49 · npm run test-iwft 51/51.
  • Verify panel (functional/regression + idiom/token-purity vs working tree): pass; no raw hex/rgba consumers; no Rust changes.

🤖 Generated with Claude Code

Ed-Barnes937 and others added 2 commits June 23, 2026 22:58
Command palette: Sessions/Commands sections + blurred scrim header. Help: two-column keyboard grid. Context menu: brief's item order with Kill (stop, keep — yellow) and Delete (remove — red) as distinct actions. New styled delete-confirm dialog routed through the existing optimistic-removal path. Code review: mauve staged-comment bubbles (you/staged) + 'Apply (n) →' count that closes the overlay on success. Theme picker: top-right anchored popover listing all themes with an active check + follow-system toggle and live preview (active check always shown; per-appearance command seeds a concrete theme). Frontend only; semantic tokens; scrim via color-mix + backdrop blur; typecheck clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Aligns page objects and scenarios with the new DOM/behavior introduced across the overhaul: sidebar liveness dots + comment/blocked chips + GROUP BY segmented control (Phase 2, #17); theme all-themes popover with .theme-modal-check + follow-system row (Phase 4); review 'Apply (n) →' label and close-on-apply (Phase 4). Test maintenance only (no behavioral weakening). npm test 49/49 and npm run test-iwft 51/51 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Ed-Barnes937 Ed-Barnes937 changed the base branch from ui-overhaul-p3-center to main June 24, 2026 15:49
@Ed-Barnes937 Ed-Barnes937 merged commit 85e366f into main Jun 24, 2026
4 checks passed
@Ed-Barnes937 Ed-Barnes937 deleted the ui-overhaul-p4-overlays branch June 24, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant