Replace bobFacts with menuSuggestion in rag docs#113
Merged
Conversation
tagboola
commented
May 10, 2024
Comment on lines
-127
to
-130
| It uses the local file-based vector similarity retriever | ||
| that Genkit provides out-of-the box for simple testing and prototyping (_do not | ||
| use in production_) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is duplicated below on line 169.
MichaelDoyle
approved these changes
May 10, 2024
| @@ -124,10 +124,6 @@ Embedding model support is provided through the following plugins: | |||
| The following examples show how you could ingest a collection of PDF documents | |||
| into a vector database and retrieve them for use in a flow. | |||
Contributor
There was a problem hiding this comment.
Consider adding a blurb about what the sample(s) do (read in restaurant menus and answer questions about them).
kevinthecheung
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I punted on completely revamping the docs and just replaced the instances of bob facts with menu examples