ci(py/genkit): select plugins and core to publish and some minor fixes#4722
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces more granular control over the publishing process, allowing certain plugins to be excluded from publishing while still being version-bumped. It also adds filtering capabilities to the plan command. The refactoring to a centralized resolve_umbrella_version function is a great improvement for consistency and maintainability.
I've found a couple of areas for improvement:
- A bug in the new logging configuration that prevents the
plancommand from being quiet by default. - An instance of variable shadowing that could make the code harder to maintain.
My detailed comments provide suggestions to address these points. Overall, these are solid changes that enhance the release tooling.
0a10092 to
f8b821e
Compare
f8b821e to
b12fef0
Compare
Uh oh!
There was an error while loading. Please reload this page.