Skip to content

Add role-based input guard for contribution submissions #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoaquinBN merged 1 commit into from
Jan 9, 2026
Merged

Add role-based input guard for contribution submissions #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions frontend/src/lib/components/ContributionSelection.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@

let validatorTabDisabled = $derived(!isValidator && !stewardMode);
let builderTabDisabled = $derived(!isBuilder && !stewardMode);
let currentCategoryDisabled = $derived(
(selectedCategory === 'validator' && !isValidator && !stewardMode) ||
(selectedCategory === 'builder' && !isBuilder && !stewardMode)
);

let contributionTypes = $state([]);
let missions = $state([]); // All missions
Expand Down Expand Up @@ -275,8 +279,7 @@
class:active={selectedCategory === 'validator'}
class:disabled={validatorTabDisabled}
style={selectedCategory === 'validator' ? 'background: #e0f2fe; color: #0369a1;' : ''}
onclick={() => !validatorTabDisabled && selectCategory('validator')}
disabled={validatorTabDisabled}
onclick={() => selectCategory('validator')}
>
Validator
</button>
Expand All @@ -286,25 +289,12 @@
class:active={selectedCategory === 'builder'}
class:disabled={builderTabDisabled}
style={selectedCategory === 'builder' ? 'background: #ffedd5; color: #c2410c;' : ''}
onclick={() => !builderTabDisabled && selectCategory('builder')}
disabled={builderTabDisabled}
onclick={() => selectCategory('builder')}
>
Builder
</button>
</div>

{#if validatorTabDisabled || builderTabDisabled}
<div class="category-locked-message">
{#if validatorTabDisabled && builderTabDisabled}
Complete a journey to submit contributions: <a href="#/validators/waitlist">Validator Waitlist</a> or <a href="#/builders/welcome">Builder Welcome</a>
{:else if validatorTabDisabled}
<a href="#/validators/waitlist">Complete the Validator Waitlist journey</a> to submit validator contributions.
{:else}
<a href="#/builders/welcome">Complete the Builder Welcome journey</a> to submit builder contributions.
{/if}
</div>
{/if}

<!-- Contribution Type Dropdown/Search -->
<div class="contribution-type-selector">
<div class="dropdown-container" class:last-element={!selectedContributionType} class:dropdown-open={dropdownOpen}>
Expand All @@ -317,17 +307,17 @@
<input
type="text"
class="search-input"
placeholder={loading ? "Loading..." : disabled ? "Locked to mission" : "Select or search contribution type..."}
placeholder={loading ? "Loading..." : disabled ? "Locked to mission" : currentCategoryDisabled ? "Role required" : "Select or search contribution type..."}
bind:value={searchQuery}
oninput={handleSearchInput}
onfocus={handleSearchFocus}
onblur={handleSearchBlur}
disabled={loading || disabled}
disabled={loading || disabled || currentCategoryDisabled}
/>
<button
class="dropdown-arrow"
onclick={handleDropdownClick}
disabled={loading || disabled}
disabled={loading || disabled || currentCategoryDisabled}
>
<svg width="12" height="12" viewBox="0 0 12 12" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M3 4.5L6 7.5L9 4.5" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"/>
Expand Down Expand Up @@ -447,6 +437,16 @@
{/if}
</div>
{/if}

{#if currentCategoryDisabled}
<div class="category-locked-message">
{#if selectedCategory === 'validator'}
You need to be a validator to submit validator contributions. You can enter the <a href="#/validators/waitlist">Validator Waitlist</a>.
{:else}
Complete the <a href="#/builders/welcome">Builder Welcome journey</a> to submit builder contributions.
{/if}
</div>
{/if}
</div>
</div>

Expand Down