fix: show contract address on testnet deploys#281
Conversation
Add Bradbury testnet to built-in networks. Update docs and guides to default to testnet-bradbury as the developer-facing testnet. Requires genlayer-js with testnetBradbury export.
The deploy command read contract address from result.data.contract_address which only exists on localnet/studio. On testnet, the address is in result.txDataDecoded.contractAddress from the decoded RLP calldata.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR transitions the codebase from testnet-asimov to testnet-bradbury, bumps the genlayer-js dependency to ^0.21.0, refactors contract deployment to handle address retrieval from both localnet/studio and testnet sources, and restructures smoke tests to support multi-network execution. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Contract Address: undefinedon testnettxDataDecoded.contractAddress(testnet path) with fallback todata.contract_address(localnet path)Test plan
npm run buildsucceedsSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores