Skip to content

fix: work around asyncssh/fido2 AttributeError on Python 3.14 non-Windows #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gensyn merged 3 commits into from
Apr 19, 2026
Merged

fix: work around asyncssh/fido2 AttributeError on Python 3.14 non-Windows #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66e5d63
Initial plan
Copilot Apr 18, 2026
93b5cc5
fix: pre-import fido2.client.windows to avoid AttributeError on Pytho…
Copilot Apr 18, 2026
cffc39f
fix: add debug logging when fido2.client.windows is unavailable
Copilot Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,28 @@

import logging
import socket
import sys
from pathlib import Path
from typing import Any

_LOGGER = logging.getLogger(__name__)

# asyncssh optionally imports fido2.client.windows for Windows WebAuthn support.
# fido2's Windows-specific module (win_api) uses ctypes.HRESULT, which Python 3.14
# removed on non-Windows platforms, causing an AttributeError that asyncssh does not
# catch (it only catches ImportError in that code path). Pre-attempt the import here
# so that on failure we can replace the broken sys.modules entry with None, which
# makes Python raise ImportError instead — and asyncssh handles that gracefully.
if sys.platform != "win32":
try:
import fido2.client.windows # noqa: F401
except (ImportError, OSError, AttributeError) as _fido2_err:
Comment on lines +28 to +30
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# noqa: F401 won’t silence pylint’s unused-import check (and the workflow doesn’t disable unused-import), so this line is likely to fail CI. Prefer a pylint suppression (# pylint: disable=unused-import) or avoid binding an unused name by using importlib.import_module("fido2.client.windows") instead of a plain import.

Copilot uses AI. Check for mistakes.
_LOGGER.debug(
"fido2.client.windows unavailable (%s); asyncssh Windows WebAuthn support disabled",
_fido2_err,
)
sys.modules["fido2.client.windows"] = None # type: ignore[assignment]
Comment on lines +27 to +35
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround changes module import-time behavior on non-Windows by mutating sys.modules. There’s currently no unit test covering the failure path (e.g., simulating fido2.client.windows raising AttributeError) to ensure coordinator.py still imports and the negative-cache entry is installed; adding one would help prevent regressions on Python 3.14+.

Copilot uses AI. Check for mistakes.

from asyncssh import HostKeyNotVerifiable, KeyImportError, PermissionDenied, connect, read_known_hosts

from homeassistant.const import CONF_USERNAME, CONF_PASSWORD, CONF_HOST, CONF_COMMAND, CONF_TIMEOUT
Expand All @@ -35,8 +54,6 @@
CONST_DEFAULT_TIMEOUT,
)

_LOGGER = logging.getLogger(__name__)


class SshCommandCoordinator:
"""Single owner of all SSH I/O for the SSH Command integration.
Expand Down
Loading