Skip to content

Refactor coordinator.py by removing workaround for asyncssh #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gensyn merged 1 commit into from
May 9, 2026
Merged

Refactor coordinator.py by removing workaround for asyncssh #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,9 @@

import logging
import socket
import sys
from pathlib import Path
from typing import Any

_LOGGER = logging.getLogger(__name__)

# asyncssh optionally imports fido2.client.windows for Windows WebAuthn support.
# fido2's Windows-specific module (win_api) uses ctypes.HRESULT, which Python 3.14
# removed on non-Windows platforms, causing an AttributeError that asyncssh does not
# catch (it only catches ImportError in that code path). Pre-attempt the import here
# so that on failure we can replace the broken sys.modules entry with None, which
# makes Python raise ImportError instead — and asyncssh handles that gracefully.
if sys.platform != "win32":
try:
import fido2.client.windows # noqa: F401
except (ImportError, OSError, AttributeError) as _fido2_err:
_LOGGER.debug(
"fido2.client.windows unavailable (%s); asyncssh Windows WebAuthn support disabled",
_fido2_err,
)
sys.modules["fido2.client.windows"] = None # type: ignore[assignment]

from asyncssh import HostKeyNotVerifiable, KeyImportError, PermissionDenied, connect, read_known_hosts

from homeassistant.const import CONF_USERNAME, CONF_PASSWORD, CONF_HOST, CONF_COMMAND, CONF_TIMEOUT
Expand All @@ -54,6 +35,8 @@
CONST_DEFAULT_TIMEOUT,
)

_LOGGER = logging.getLogger(__name__)


class SshCommandCoordinator:
"""Single owner of all SSH I/O for the SSH Command integration.
Expand Down
Loading