Conversation
|
Looks like there are conflicts now, can you check them? |
|
This should do it. Thanks for the ping! |
gonsoos
force-pushed
the
dev
branch
2 times, most recently
from
2419d20 to
9db7434
Compare
|
You plan to add any further commits? I guess touching so many files would produce more conflicts if this PR is left for too much time without being merge. |
gonsoos
force-pushed
the
dev
branch
2 times, most recently
from
7efea07 to
702d01f
Compare
Yes, I want to fix the whole repo. (278 ebuilds to go; this should and could probably be automated)
I'd prefer merging these changes in batches, instead of waiting for the rest :') |
gonsoos
force-pushed
the
dev
branch
4 times, most recently
from
976a3a5 to
435449a
Compare
|
@antecrescent is this ready to merge, then? If not, could you change this PR to a draft until it is? |
Manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
I manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
I manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
I manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
I manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
I manually went through some entries for `pkgcheck scan -c VariableOrderCheck`. Misc updates: UnusedEclassesCheck RESTRICT+=" .." -> RESTRICT=".." Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@MrRoy Yes, please merge it. There might have been a miscommunication.. In an earlier comment (#170 (comment)), I intended to say that I do plan to fix the variable order for all ebuilds in ::guru, but that I will do so in separate PRs to avoid the need for constant rebases and to keep the work of reviewing manageable. Thank you for keeping an eye on the PR! |
|
@antecrescent ok perfect, then I will merge this. |
3 participants
I manually went through some entries for
pkgcheck scan -c VariableOrderCheck.I'll keep pushing commits by category, feel free to merge this whenever.