PB-1877 Directly link to Terms of Use #patch#44
Merged
asteiner-swisstopo merged 2 commits intomasterfrom Sep 23, 2025
Merged
Conversation
The page currently pointed at is going to change with the go-live of the Tech Docs. This is labelled with PB-1877 because it's a small fix that I want to use to test whether CodeBuild etc works as expected. Ultimately, the PR out of this change should contain a description with a preview link to a version on DEV of the Tech Docs that corresponds to the status of the branch.
asteiner-swisstopo
changed the title
For test links, we need to take into account that there is a "/preview/feat-PB-1234-my-branch" in between. If we don't add this to the static asset links, it will result in broken styling, missing images and broken page links. See ["Base URL"](https://vitepress.dev/guide/asset-handling#base-url) in the VitePress docs.
asteiner-swisstopo
requested review from
ltflb-bgdi and
pedroslvieira
and removed request for
ltflb-bgdi
pedroslvieira
approved these changes
Sep 23, 2025
asteiner-swisstopo
deleted the
bug-PB-1877-fix-link-to-terms-of-use-in-iframe-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a link on the "Embed in an iframe" to point to the General Terms of Use of geo.admin.ch. Before, it pointed to the iFrame page of the CMS.
This is to test the changes made in the CI here:
Creation of the PR should:
[doc-tech-pr](https://974517877189-54ujtveq.eu-central-1.console.aws.amazon.com/codesuite/codebuild/974517877189/projects/doc-tech-pr/history?region=eu-central-1)to build the website on the current Git branch.aws s3 cp) the build artifacts ons3://doc-tech-dev-swisstopo.👉 EDIT: Additionally added the
baseparameter to the Vitepress config such that it prependspreview/feat-pb-1234-my-branchto to all static asset paths. See the corresponding change inbuildspec_pr.yml, PR https://github.com/geoadmin/infra-terraform-bgdi/pull/1179.Test link