PB-1866: Make delete drawing window easier to understand #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltkum
force-pushed
the
feat-PB-1866-make-delete-modal-easier-to-understand
branch
3 times, most recently
from
3598028 to
310feb6
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1866-make-delete-modal-easier-to-understand
|
| Run status |
|
| Run duration | 05m 12s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
260
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Aug 5, 2025
ltkum
force-pushed
the
feat-PB-1866-make-delete-modal-easier-to-understand
branch
from
310feb6 to
b235342
Compare
pakb
reviewed
Aug 5, 2025
packages/mapviewer/src/modules/drawing/components/DrawingToolbox.vue
Outdated
Show resolved
Hide resolved
ltkum
force-pushed
the
feat-PB-1866-make-delete-modal-easier-to-understand
branch
2 times, most recently
from
93e37a2 to
853a508
Compare
pakb
reviewed
Aug 5, 2025
packages/mapviewer/src/modules/drawing/components/DrawingToolbox.vue
Outdated
Show resolved
Hide resolved
ltkum
force-pushed
the
feat-PB-1866-make-delete-modal-easier-to-understand
branch
from
853a508 to
2812dbe
Compare
Issue: When people click on the "delete" button in drawing, and confirm it by clicking 'OK', they realize afterwards that they decided to delete all their work and sometimes ask us to retrieve their lost data. Fix: We are now more explicit about what we're deleting, and the modal message now clearly says "Delete Everything". We Also added the code that would allow us to add custom confirm / cancel messages and icons for every modal we use.
ltkum
force-pushed
the
feat-PB-1866-make-delete-modal-easier-to-understand
branch
from
2812dbe to
0b3abff
Compare
pakb
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When people click on the "delete" button in drawing, and confirm it by clicking 'OK', they realize afterwards that they decided to delete all their work and sometimes ask us to retrieve their lost data.
Fix: We are now more explicit about what we're deleting, and the modal message now clearly says "Delete Everything". We Also added the code that would allow us to add custom confirm / cancel messages and icons for every modal we use.
Test link