add Factory for Algolia Place Provider #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabex
force-pushed
the
feature/algolia-place-provider-factory
branch
from
74686bb to
3b20137
Compare
Fabex
force-pushed
the
feature/algolia-place-provider-factory
branch
from
d85fcae to
b936dcf
Compare
|
I would be glad to have this available :) ! |
tgalopin
reviewed
Oct 16, 2018
| ]); | ||
|
|
||
| $resolver->setAllowedTypes('httplug_client', ['object', 'null']); | ||
| $resolver->setAllowedTypes('apiKey', ['string']); |
There was a problem hiding this comment.
What about using api_key and app_id instead to be consistent with the other factories?
Member
|
@Fabex are you willing to finish this? |
Member
|
This was implemented in #247. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my pull request on geocoder-php/Geocoder geocoder-php/Geocoder#854
is merged and released, I forgot to make the pull request on BazingaGeocoderBundle.
So I add the Factory for Algolia Place Provider