-
Notifications
You must be signed in to change notification settings - Fork 110
Add Algolia provider factory #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8c157c to
e0fe85c
Compare
|
@Nyholm please, when you'll have time check what's going on with github actions, why the status isn't reported :) |
|
Thank you. Could you rebase on master and also add a small test for this provider? |
3c36504 to
339c14b
Compare
On it, btw CS fixer seems to be failing unrelated to the actual code it parses. |
Nyholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I still miss a test.
Also, CI complained about your AlgoliaFactory.php. I made a small comment to highlight that.
Add tests for Algolia factory fix typo
339c14b to
d9c6589
Compare
@Nyholm Test config added, line removed :) |
Nyholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This PR was made because i noticed a discrepancy between geocoder-php/Geocoder listed provider support and here. The same effort was done as part of #207 but it remained unfinished for more than a year. I fixed the option names as requested in CR from @tgalopin and @Nyholm on the #207.