Skip to content

Conversation

@markomitranic
Copy link
Contributor

@markomitranic markomitranic commented Sep 17, 2019

This PR was made because i noticed a discrepancy between geocoder-php/Geocoder listed provider support and here. The same effort was done as part of #207 but it remained unfinished for more than a year. I fixed the option names as requested in CR from @tgalopin and @Nyholm on the #207.

@norkunas
Copy link
Member

@Nyholm please, when you'll have time check what's going on with github actions, why the status isn't reported :)

@Nyholm
Copy link
Member

Nyholm commented Sep 19, 2019

Thank you.

Could you rebase on master and also add a small test for this provider?

@markomitranic
Copy link
Contributor Author

Thank you.

Could you rebase on master and also add a small test for this provider?

On it, btw CS fixer seems to be failing unrelated to the actual code it parses.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I still miss a test.
Also, CI complained about your AlgoliaFactory.php. I made a small comment to highlight that.

Add tests for Algolia factory

fix typo
@markomitranic
Copy link
Contributor Author

markomitranic commented Sep 19, 2019

Thank you.

I still miss a test.
Also, CI complained about your AlgoliaFactory.php. I made a small comment to highlight that.

@Nyholm
Thanks for the explanation, i didn't see the minus in the report at first :/

Test config added, line removed :)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 88f7847 into geocoder-php:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants