Skip to content

Throw InvalidCredentialException when credentials not accepted with GoogleMapsBusinessProvider #314

@Byte-Lab

Description

@Byte-Lab

Currently, it appears as though when an incorrect clientId and/or privateKey are given when using GoogleMapsBusinessProvider, that a NoResultException is thrown rather than the more informative and accurate InvalidCredentialsException. This is rather problematic because a NoResultException is also thrown when the correct credentials are given, but when a query is sent to Google that does not return a result.

From what I can tell, the following providers currently throw the InvalidCredentialsException:

  1. BaiduProvider
  2. BingMapsProvider
  3. ChainProvider
  4. CloudMadeProvider
  5. GeoIPsProvider
  6. GeonamesProvider
  7. IGNOpenLSProvider
  8. IpInfoDbProvider
  9. MapQuestProvider
  10. MaxMindProvider
  11. TomTomProvider

Does anyone know why this isn't implemented for GoogleMapsBusinessProvider? If it is an easy fix I can make a PR early this week.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions