Add a ResultFactory to easily create ResultInterface instances

[willdurand]

ping @Baachi, @toin0u
see #181

WDYT?

[Baachi]

Why you don't add a ResultFactoryInterface?

[willdurand]

What would be the use case? I don't want people to define another
createFromArray() method.

On Wed, Jan 16, 2013 at 10:29 PM, Markus Bachmann
notifications@github.comwrote:

Why you don't add a ResultFactoryInterface?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/182#issuecomment-12341113.

[Baachi]

Yes, make sense. Maybe the best implemention currently.

[toin0u]

I like this a lot !! That's cool :)

Now, we just need to implement ProviderInterface (or extend existing providers) to make our own provider which will return the ResultInterface we made with the factory :)

Should the method formatString be protected ? Or I'm missing something ?

[Baachi]

@toin0u I think the provider should not decide which result should be generated.
Geocoder tries to provides a consistently API between different providers. This means, you can simple change your provider and no error will be occurs. If the provider decide which Result object will be returned, this will not work anymore.

The developer should decide which Result object should be return (this was currently not possible). But now the developer can write his own ResultFactory and generate his own ResultObject.

@willdurand Do you agree?

[willdurand]

The provider won't decide which result should be generated, never.

@Baachi could not have been more right, thank you!

[toin0u]

@Baachi I see your point and of course I don't think the provider should decide which Result object will be returned :)

[toin0u]

With:

Now, we just need to implement ProviderInterface (or extend existing providers) to make our own provider which will return the ResultInterface we made with the factory :)

I meant that users should do this not Geocoder ! Sorry, my bad...

[willdurand]

ah yes ;)
I missed your point, but now I see. No problem

On Thu, Jan 17, 2013 at 3:47 PM, Antoine Corcy notifications@github.comwrote:

With:

Now, we just need to implement ProviderInterface (or extend existing
providers) to make our own provider which will return the ResultInterface
we made with the factory :)

I meant that users should do this not Geocoder ! Sorry, my bad...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/182#issuecomment-12370671.

[toin0u]

I should read my comment twice.. :S
But I'm happy that we agree ! :)

[Baachi]

No problem :)
I'm happy that we all agree, too^^