Fix encoding for geoip provider

[EmmanuelVella]

Geoip module return ISO-8859-1 encoded strings. Special characters are broken if they are not converted to utf8 before applying a transformation (like in https://github.com/willdurand/Geocoder/blob/master/src/Geocoder/Result/AbstractResult.php#L64)

You can try with this IP : 79.120.148.112 (Bogyoszló)

[toin0u]

Good catch, we get Bogyoszl we should get Bogyoszló:

{"latitude":47.561199188232,"longitude":17.184400558472,"bounds":null,"streetNumber":null,"streetName":null,"zipcode":"","city":"Bogyoszl","cityDistrict":null,"county":null,"countyCode":null,"region":"Gyor-Moson-Sopron","regionCode":"09","country":"Hungary","countryCode":"HU","timezone":"Europe\/Budapest"}

Maybe it's better to fix the formatString method instead. @willdurand WDYT ?

[EmmanuelVella]

I tried to replace the UTF-8 string in the formatString method by mb_detect_encoding($str) : unfortunately, the detection does not work as expected as it returns UTF-8 instead of ISO-8859-1 !

[EmmanuelVella]

This seems to be a bug : http://de2.php.net/manual/de/function.mb-detect-encoding.php#55228

[toin0u]

Did you tried the strict mode in mb_detect_encoding ?

Something like:

$str = mb_detect_encoding($str, 'UTF-8', true) ? $str : utf8_encode($str);

[EmmanuelVella]

It only works with mb_detect_encoding($str, 'UTF-8, ISO-8859-1', true); ! (else it returns false)

[toin0u]

Ok, so your solution is the best I guess 👍

[EmmanuelVella]

If geoip is the only provider which returns non-utf8 strings, indeed the initial solution is maybe better !

[toin0u]

I agree :)

[willdurand]

thanks!

[Nelrann]

yes! thanks!