Skip to content

Fix encoding issue for maxmind provider #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toin0u wants to merge 1 commit into from
Closed

Fix encoding issue for maxmind provider #396

toin0u wants to merge 1 commit into from

Conversation

@toin0u
Copy link
Member

@toin0u toin0u commented Jan 6, 2015

This is related to geocoder-php/BazingaGeocoderBundle#84 but a patch should be written for the 2.x version as well.

@willdurand
Copy link
Member

willdurand commented Jan 7, 2015

Merged in 11f8bbf.

@toin0u note that I re-commited your commit, changing your commit message. This was necessary as I merged your patch in 2.x, and then merged 2.x into master. However, tests were different between both branches.

@willdurand willdurand closed this Jan 7, 2015
@toin0u
Copy link
Member Author

toin0u commented Jan 7, 2015

@willdurand no problem :) Thanks !

@toin0u toin0u deleted the hotfix-maxmind-encoding branch January 7, 2015 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toin0u @willdurand