Finalize providers #540
Merged
Finalize providers #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Oct 13, 2016
| * @param bool $useSsl Whether to use an SSL connection (optional) | ||
| * @param string $apiKey Google Geocoding API key (optional) | ||
| * @return GoogleMaps | ||
| */ |
Member
There was a problem hiding this comment.
Is this a factory method? Should it be static?
$gBusiness = GoogleMaps::business(...);
Member
|
Good job. I like this PR. Let me know when you done with your changes. |
Member
|
I like it too. |
Contributor
Author
|
I think this PR is done. |
Member
|
👍 |
Member
|
Thank you @unkind. Great work! |
Contributor
Author
|
We shouldn't forget to fix the bundle: https://github.com/geocoder-php/BazingaGeocoderBundle |
norkunas
pushed a commit
to norkunas/Geocoder
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #537 for details.
This PR is not ready for merge,
GoogleMapsBusinesstests were not ported yet.