Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented May 20, 2017

This will fix #598

This PR will also update *Query::getData to be more DX.

@Nyholm Nyholm added this to the 4.0.0 milestone May 20, 2017
@willdurand willdurand requested a review from Baachi May 20, 2017 12:16
@Nyholm
Copy link
Member Author

Nyholm commented May 20, 2017

Ping @svrdlic. What do you think of the getData($name, $default = null) and getAllData() functions? Do they make sense? Is there a better name than getAllData() ?

@willdurand
Copy link
Member

👍

@Nyholm Nyholm merged commit ed400cc into geocoder-php:master May 26, 2017
@Nyholm Nyholm deleted the issue-598 branch May 26, 2017 09:12
@svrdlic
Copy link
Contributor

svrdlic commented May 26, 2017

Sorry for late response. Function names are very self-descriptive.. getAllData() to get array of data, and getData($name, $default=null) to get concrete data value, sounds great to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nominatim provider

3 participants