Removed return types #820
Merged
Removed return types #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrodala
reviewed
Feb 12, 2018
| * | ||
| * @return GoogleAddress | ||
| */ | ||
| public function withId(string $id = null): self |
There was a problem hiding this comment.
Technically this is not really accurate anways. It should be GoogleAddress instead since it's not the same instance that is returned when calling these methods.
Member
Author
There was a problem hiding this comment.
Writing :GoogleAddress or :self is the same. :self means the same class. Not the same object.
There was a problem hiding this comment.
OK, you are right. So far I had in mind that this was the native @return $this solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to keep this, but it is a BC break. :/