Custom Keybinds lets you stack the exit confirmation window

[Nebularzz]

This can also cause a crash.

Recreation steps:

1. Enable exit confirmation
2. Press: ESC, ESC, Space, ESC, ESC
   Now 2 windows are stacked.
   You can continue stacking by pressing: Space, ESC, ESC

Next up to cause the segfault, you need to:

1. Click and hold exit.
2. Hold Space.
3. Press ESC.
4. Release holding exit.

The game should crash now.
If it doesn't, give it another try.

Another it could crash by stacking windows, is to just spam closing the windows with cancel. This is a lot less likely to crash though, and is pretty much random.

ck.crash.mp4

[Aktimoose]

The main issue here is that unpausing while the Confirm Exit menu is on at all is possible. Every issue listed here appears to result from that.

Behaviour with the mod (and nothing else):

Replay.2024-04-05.00-56-46-00.00.10.649-00.00.17.400.mov

Behaviour in vanilla:

Replay.2024-04-05.00-58-51-00.00.19.858-00.00.25.000.mov

[Fleeym]

Hey there, sorry for the late response, I got around to checking this, fixed in the next release, will let you know when it's out :)

[Fleeym]

Fixed in v1.5.3

[Aktimoose]

The window stacking bug appears to be fixed in 1.5.3, but the Confirm Exit unpause behaviour still isn't identical to Vanilla. Pressing space twice while the confirm exit window is up unpauses it, while in vanilla it shouldn't ever unpause the game in that state. (not sure if this should be a separate opened issue because it's related)

[Fleeym]

Ah, I understand, I'll make it cancel out the action if the popup is present

[Fleeym]

v1.5.4 now replicates the vanilla behaviour (it's a bit of a hacky fix, do let me know if it still does anything bad)