fix(update): restart lerd-ui/watcher/tray after self-update#197
Merged
Conversation
The self-update path replaces the on-disk binary but leaves the long-running user services executing the old inode, so lerd-ui keeps reporting the pre-update version until something else restarts it. Restart any currently-active lerd user units at the end of runUpdate so the freshly installed binary takes effect immediately. Disabled units are left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lerd updatereplaces the on-disk binary, runs install, and rebuilds PHP-FPM containers, but never restarts the long-running lerd user services. Linux keeps the old inode alive for processes that still have the binary open, solerd serve-ui,lerd-watcher, andlerd-traykeep executing the pre-update code and report the old version until something else restarts them (reboot, manual kill, tray Quit).This PR adds a final step to
runUpdatethat probeslerd-ui,lerd-watcher, andlerd-trayuser units and restarts any that are currently active. Disabled services are left alone so the flow keeps working on machines where autostart is off. Restart failures are reported as warnings and do not abort the update.