fix(ui): label FrankenPHP log tab and stream from the right container#243
Merged
fix(ui): label FrankenPHP log tab and stream from the right container#243
Conversation
Sites running the frankenphp runtime still rendered the container logs tab as "PHP-FPM" and pointed its SSE stream at the shared lerd-php*-fpm container, which does not exist for per-site FrankenPHP deployments. Route the tab through the lerd-fp-<site> container in both the web UI and the TUI, update enrichFPM so fpm_running reflects the frankenphp container, and rename the tab accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lerd-php*-fpmcontainer, which does not exist for per-site FrankenPHP deployments. The tab now reads "FrankenPHP" and streams fromlerd-fp-<site>.enrichFPMnow checks the frankenphp container when a site's runtime isfrankenphp, sofpm_runningreflects reality and the site detail panel actually opens the log stream.