fix(macos): strip IPv6 PublishPort lines before writing launchd plist#249
Merged
fix(macos): strip IPv6 PublishPort lines before writing launchd plist#249
Conversation
gvproxy cannot bind two specific host IPs (127.0.0.1 and ::1) on the same port simultaneously — it tries to bind 0.0.0.0:port internally and fails with 'address already in use', leaving containers in Created state instead of running. Strip bracketed IPv6 PublishPort= lines in WriteContainerUnit so only IPv4 bindings reach podman run on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gvproxy cannot bind two specific host IPs (
127.0.0.1and[::1]) on the same port simultaneously — it tries to bind0.0.0.0:portinternally and fails withlisten tcp4 :PORT: bind: address already in use, leaving containers inCreatedstate instead of running.PairIPv6Binds(called inWriteQuadletDiff) adds[::1]:PORT:PORTlines alongside every127.0.0.1:PORT:PORTline. On Linux these are passed to systemd/quadlet which handles them correctly. On macOS,WriteContainerUnitconverts them topodman run -pflags, and gvproxy chokes on the dual binding.The fix strips bracketed IPv6
PublishPort=lines inWriteContainerUnitso only IPv4 bindings reachpodman runon macOS.