fix: react to network changes while idle and skip disabled picker versions - #595
Merged
Conversation
…sions The DNS watcher routed a host network change through the same idle backoff as the routine poll, so a VPN connect or disconnect or a wifi switch was dropped roughly nine times out of ten whenever the session was idle or the screen was locked. That is exactly when those events fire, a laptop waking from sleep and reconnecting on the lock screen, so containers were left on the stale resolver until the next every-tenth poll. A link-triggered tick now bypasses the backoff and re-probes immediately while the routine timer keeps backing off to save battery. The TUI version picker moved its cursor with bare increments while the modal was open, with no skip over disabled out-of-range versions, because the skip logic only lived in the moveCursor branch that the modal key handler never reaches. The arrows could park on a dimmed version and pressing enter then silently did nothing. The skip now lives in a shared movePickerCursor helper used by both paths, and home and end land on the first and last selectable version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #594
The DNS watcher routed a host network change through the same idle backoff as the routine poll, so a VPN connect or disconnect or a wifi switch was dropped roughly nine times out of ten whenever the session was idle or the screen was locked. That is exactly when those events fire, a laptop waking from sleep and reconnecting on the lock screen, so containers were left on the stale resolver until the next every-tenth poll. A link-triggered tick now bypasses the backoff and re-probes immediately while the routine timer keeps backing off to save battery.
The TUI version picker moved its cursor with bare increments while the modal was open, with no skip over disabled out-of-range versions, because the skip logic only lived in the moveCursor branch that the modal key handler never reaches. The arrows could park on a dimmed version and pressing enter then silently did nothing. The skip now lives in a shared movePickerCursor helper used by both paths, and home and end land on the first and last selectable version.