fix(cli): warn when a host worker's deps are missing, and route update output through the feedback layer#616
Merged
Conversation
…e output through the feedback layer A freshly linked project that declares a host worker like vite but hasn't had its JS dependencies installed used to drop that worker silently, so it just read as "vite isn't running" with no clue why. Both the link path and WorkerStartForSite now surface a single shared message through hostWorkerNotReadyMsg, which fires only for a host worker on a node project and points at lerd setup rather than a bare npm ci so the advice still holds for bun, yarn and pnpm projects. The message lives in one place so the preflight gate and the link-time skip read identically, and it stays empty for container workers so they keep their existing dependency note. The update command's service-restart and rollback output now speaks the same styled feedback vocabulary as the rest of the CLI instead of the old ==> and --> prefixes. A restart that doesn't take is rendered with a new amber Step.Warn rather than a red cross, since the binary swap already succeeded and a stuck restart is a warning, not a failure of the update itself.
iabduul7
pushed a commit
to iabduul7/lerd
that referenced
this pull request
Jun 26, 2026
…-worker-readiness (cherry picked from commit b2311d7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two post-1.26.0 CLI fixes.
A freshly linked project that declares a host worker like vite but hasn't installed its JS dependencies used to drop that worker silently, so it just read as vite not running with no clue why. Both the link path and WorkerStartForSite now surface a single shared message through hostWorkerNotReadyMsg, which fires only for a host worker on a node project and points at lerd setup rather than a bare npm ci so the advice still holds for bun, yarn and pnpm projects. The message lives in one place so the preflight gate and the link-time skip read identically, and it stays empty for container workers so they keep their existing dependency note.
The update command's service-restart and rollback output now speaks the same styled feedback vocabulary as the rest of the CLI instead of the old ==> and --> prefixes. A restart that doesn't take is rendered with a new amber Step.Warn rather than a red cross, since the binary swap already succeeded and a stuck restart is a warning, not a failure of the update itself.