Include utilities namespace wherever necessary#6217
Conversation
b27c044 to
41bdc86
Compare
41bdc86 to
c75dfb8
Compare
c75dfb8 to
0d886ce
Compare
|
I introduced a change after noticing a problem in #6215: There are two separate cases:
My previous solution of simply including I updated the code and added a comment to make sure this logic is documented. The logic for all symbols in the Utilities namespaces now look approximately like this: Not the prettiest solution, but at least this way we should avoid all future problems with these namespaces. The alternative was to specify for each use of @tjhei: Can you take another look? Sorry we overlapped with your review and my modification. |
|
Maybe we should get rid of the |
We could, I wouldnt be opposed to it. The material model already uses |
This PR fixes an issue that appeared in #6215: Not all of ASPECT's namespaces named
Utilitiescontain a directiveusing namespace dealii::Utilities. This can lead to hard to understand error messages like thatUtilities::MPI:...cannot be found, even if the ASPECT file in question was not changed at all (e.g. because it was grouped into a different unity build file that contained a newUtilitiesnamespace). This PR introducesusing namespace dealii::Utilitiesinto every file that introduces anUtilitynamespace.