Prevent negative adiabatic pT conditions in a benchmark#6798
Merged
tjhei merged 1 commit intogeodynamics:mainfrom Nov 29, 2025
Merged
Prevent negative adiabatic pT conditions in a benchmark#6798tjhei merged 1 commit intogeodynamics:mainfrom
tjhei merged 1 commit intogeodynamics:mainfrom
Conversation
This was referenced Nov 28, 2025
tjhei
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the last few days we had failures of the deal.II development tester in the test
sol_cx_particleslike here: https://github.com/geodynamics/aspect/actions/runs/19635945253/job/56226561004?pr=6795#step:6:2028The failure seems unrelated to any code change in either deal.II or ASPECT and at first I was a bit stumped as to what is happening. But looking at the benchmark I realize why this setup is a bit problematic. The adiabatic conditions start from p=0 and T=0. Density in parts of this benchmark is negative (or 0) and gravity is 1. Therefore the adiabatic reference profile contains negative pressures, which triggers the assert. Why this was not a problem in the past I cannot explain. We can argue if the assert is too sensitive (negative pressures in benchmark solutions are not impossible), but an easier fix is to change the start point of the reference profile. Since the profile is not used in this benchmark nothing will change.
I also have no clue why this is a problem for the particle test, but not the corresponding model with compositional fields, I can only guess that it is due to FP rounding errors.
Anyway, this should fix the confusing test failures.