Update no normal flux boundary conditions and other BCs after mesh deformation#6819
Closed
gassmoeller wants to merge 2 commits intogeodynamics:mainfrom
Closed
Update no normal flux boundary conditions and other BCs after mesh deformation#6819gassmoeller wants to merge 2 commits intogeodynamics:mainfrom
gassmoeller wants to merge 2 commits intogeodynamics:mainfrom
Conversation
Member
|
@gassmoeller, I've extended these commits here: #6829 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step towards resolving #6818, but there is more to figure out, this is not complete yet (but I think the changes in this PR are necessary either way).
Changes in this PR:
compute_no_normal_flux_constraintsintocompute_current_velocity_boundary_constraintsto make sure they are updated during the model run (e.g. if the mesh boundary changes)compute_current_velocity_boundary_constraintsis called again after mesh deformation if mesh deformation is active to ensure that all boundary conditions are applied correctly to the new (deformed) meshAs described in #6818 there are other problems as well, so I am not sure we should merge this already before we have figured out what else is not working.