Improve comments in advection assemblers#6861
Merged
gassmoeller merged 1 commit intogeodynamics:mainfrom Feb 20, 2026
Merged
Conversation
Member
same as deal.II, I would suggest. |
tjhei
approved these changes
Feb 19, 2026
Member
Author
|
/rebuild |
bangerth
reviewed
Feb 23, 2026
Contributor
bangerth
left a comment
bangerth
left a comment
There was a problem hiding this comment.
Interesting -- overall nice improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just improvements to the comments of the advection assemblers.
Disclaimer: I am playing around with OpenAI Codex and these were the suggestions I got for improving our comments in those two files. I had to tweak one or two for style, and had to revert one because it distorted the meaning of the comment slightly, but overall this is a pretty convenient (and relatively safe) way to improve our code comments.
At some point we should probably discuss how to handle chatbot generated code contributions, but I think this particular one is still a pretty safe application.