Refactor GMG global coarsening code so it uses the same block stokes preconditioning class as AMG and GMG local smoothing.#6865
Merged
gassmoeller merged 1 commit intogeodynamics:mainfrom Feb 23, 2026
Conversation
tjhei
approved these changes
Feb 21, 2026
Member
|
/rebuild |
gassmoeller
reviewed
Feb 22, 2026
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
Nice, thanks for the cleanup 👍. I have two minor comments on the code style, but everything else looks good.
Comment on lines
+1196
to
+1197
| internal::InverseVelocityBlock<GMGPreconditioner, VectorType, ABlockMatrixType> inverse_velocity_block_cheap( | ||
| A_block_matrix, |
Member
There was a problem hiding this comment.
Please be consistent about which lines you place the name of the object and the parameters to the constructor in. You currently use 3 different convection:
type name(
parameters
and
type
name (parameters,
...
and
type
name(
parameters,
...
I would use the following for long lines here and for the other lines you changed:
Suggested change
| internal::InverseVelocityBlock<GMGPreconditioner, VectorType, ABlockMatrixType> inverse_velocity_block_cheap( | |
| A_block_matrix, | |
| internal::InverseVelocityBlock<GMGPreconditioner, VectorType, ABlockMatrixType> | |
| inverse_velocity_block_cheap(A_block_matrix, | |
| ... |
Contributor
Author
There was a problem hiding this comment.
Thank you, I just made edits. Please let me know if I missed anything else.
quangx
force-pushed
the
global_coarsening_refactor
branch
from
51b9fdd to
4137a3b
Compare
quangx
force-pushed
the
global_coarsening_refactor
branch
from
c7f9770 to
f6c8f77
Compare
quangx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6806. With this pull request, GMG global coarsening uses the BlockSchurPreconditioner class instead of BlockSchurGMGPreconditioner. This means that now, the same block Schur preconditioning class is used for AMG, GMG local smoothing, and GMG global coarsening. As such, we can safely delete the BlockSchurGMGPreconditioner class.