Better describe the rationale of the SimulatorAccess base class.#6869
Merged
gassmoeller merged 1 commit intogeodynamics:mainfrom Feb 24, 2026
Merged
Better describe the rationale of the SimulatorAccess base class.#6869gassmoeller merged 1 commit intogeodynamics:mainfrom
gassmoeller merged 1 commit intogeodynamics:mainfrom
Conversation
gassmoeller
approved these changes
Feb 24, 2026
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
I like it. There is a bit of duplication with the documentation here: https://github.com/geodynamics/aspect/blob/main/doc/sphinx/user/extending/idea-of-plugins.md?plain=1#L197
However, I think this is still fine. The markdown documentation talk about the general concept and what it means for plugins, while here you discuss the programming implementation and software design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was describing the design of ASPECT to someone the other day, including the rationale of
SimulatorAccessand thought that I might as well write that up given that it's an uncommon design.