remove generation of parameters.xml / website feature#6878
Merged
gassmoeller merged 1 commit intogeodynamics:mainfrom Mar 5, 2026
Merged
remove generation of parameters.xml / website feature#6878gassmoeller merged 1 commit intogeodynamics:mainfrom
gassmoeller merged 1 commit intogeodynamics:mainfrom
Conversation
gassmoeller
approved these changes
Mar 3, 2026
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
Looks good to me, but lets keep it open for a day or two, in case someone feels strongly about it. I should mention #6880 ports a lot of the old functionality into our new parameter documentation, so this is not removing a lot of functionality, just integrating it better into our other documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter website https://aspect.geodynamics.org/doc/parameter_view/parameters.xml
uses a deprecated xslt feature that will not have browser support in the near future (and right now expanding using + doesn't work either).
A such, I would propose deleting the xml from the repo including the logic to generate it. This would also help in requiring fewer changes every month.