Prescribed condition from initial composition

[lhy11009]

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Prescribe the composition field from the initial composition fields.

Before your first pull request:

• I have read the guidelines in our CONTRIBUTING.md document.

For all pull requests:

• I have followed the instructions for indenting my code.

For new features/models or changes of existing features:

• I have tested my new feature locally to ensure it is correct.
• I have created a testcase for the new feature/benchmark in the tests/ directory.
• I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

[lhy11009]

Currently, this works for the field methods, and I don't think it works for the particle method. In the test I included, I modified from the composition_passive.prm and prescribed the composition on the left half of the domain. So the left side would stay the same value while the right side is advecting.

t = 0

t = 10

[lhy11009]

Ideally, I would want a method that works for the particle method. At least that's something I was thinking when creating the PR. However, I feel this is also useful with the field method.

[danieldouglas92]

This is great @lhy11009 thanks for this! I only had a few minor comments about cleaning up the test file and the formatting of things, but other then that I think looks great.

[lhy11009]

Hi @danieldouglas92, Thanks for reviewing my changes.
See my reply on the test file and check the comments I added to the code. Otherwise, I have resolved the conversations.

[danieldouglas92]

@lhy11009 the rest of your changes look great! Thanks for addressing them so quickly. If including the cookbook parameter file also causes the model to hang don't worry about it, but I would try adding the include statement to that cookbook file if you haven't already and see what happens.

[gassmoeller]

The code looks all good @lhy11009, and thanks for the reviews @danieldouglas92. I have some minor comments and questions, but the functionality looks all good.

[lhy11009]

Previously, there was a building issue, I think that is related to a missing header.
I added the following line to source/prescribed_solution/initial_composition.cc file:
#include <aspect/geometry_model/interface.h>
Hopefully, this addresses the issue.

[gassmoeller]

Yes, that header was missing if you do not precompiler the header files (which we usually do, but some systems may not allow that, that is why one of the testers doesnt do it).

Looks all good except for my comment about the test.

[gassmoeller]

You didnt add any output files for the test. This way we wont notice if the feature breaks. Please add one (one should be enough).

[lhy11009]

Yes, I have added two gunplot files

[gassmoeller]

/rebuild

[gassmoeller]

Ready to merge when the testers are done. (the one failing tester is unrelated)

[gassmoeller]

/rebuild

[gassmoeller]

All good to merge now.