Skip to content

Specify entropy model's adiabatic profile via function #6942

Open
RanpengLi wants to merge 1 commit into
geodynamics:mainfrom
RanpengLi:entropy-adiabatic-profile
Open

Specify entropy model's adiabatic profile via function #6942
RanpengLi wants to merge 1 commit into
geodynamics:mainfrom
RanpengLi:entropy-adiabatic-profile

Conversation

@RanpengLi
Copy link
Copy Markdown
Contributor

The chemical compositions and component's entropies can also be specified by a function. Each components will be equiliabrated using the multi-component entropy method.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@gassmoeller
Copy link
Copy Markdown
Member

Hi @RanpengLi, apologies this will have to wait a bit longer before I can look at it. Until then you can already:

  • Find out why the indent tester fails
  • Add a test case that uses the new feature
  • Add a changelog entry that described what the new feature is for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants