Update dynamic core parameter documentation#6943
Merged
alarshi merged 1 commit intoApr 28, 2026
Merged
Conversation
alarshi
approved these changes
Apr 27, 2026
Contributor
alarshi
left a comment
There was a problem hiding this comment.
Thank you for updating the documentation and testing the changes locally! It looks good to me.
The documentation files (.md) are generated automatically from the corresponding parameter declarations in the source files, so for the next PRs, you could also just make the changes in the .cc files :)
Contributor
|
/rebuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two small dynamic core parameter cleanups.
Changes:
Tm1andTm2defaults and documentation to use SI units (1/Paand1/Pa^2) instead of terapascal-based unitsGravity accelerationparameter from the dynamic core input file interface and test inputGravity model, so users should control CMB gravity through theGravity modelsubsectionThis does not add a multiplier or unit conversion in the code. It makes the documented/default values match the units already used by the formulas.
Validation:
cmake --build build-debug --target aspect -j20ASPECT_SOURCE_DIR=/home/francyrad/Documenti/aspect_debug/aspect_issue_6926_work ctest --output-on-failure -R "dynamic_core|dynamic_core_fully_molten|dynamic_core_fully_solid"Results on this x86_64 Debug setup:
dynamic_corepassesdynamic_core_fully_solidpassesdynamic_core_fully_moltenstill reports the known last-digit statistics diff on this setupRefs #6227.
Refs #6926.