You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This reworks the old #6918 branch on top of current main and keeps the patch limited to the serialization hooks requested in review.
The PR adds serialize(), save(), and load() to the dynamic core boundary temperature plugin. It serializes the dynamic core state plus the small amount of runtime state needed for checkpoint/restart to restore the plugin object itself, including the OES data table when present. It does not add extra restart-path logic in update().
manual checkpoint/resume smoke test for dynamic_core: resumed run continues with Dynamic core data updated
ASPECT_SOURCE_DIR=/home/francyrad/Documenti/aspect_debug/aspect_pr_6918_work ctest --output-on-failure -R dynamic_core: dynamic_core and dynamic_core_fully_solid pass; dynamic_core_fully_molten only differs in the last digit of two statistics time values on this machine
Note on the current no-unity-build CI failure: it fails during CMake configuration before compiling this patch because the runner installs/finds deal.II 9.3.2, while current ASPECT requires a newer deal.II.
Relevant log line:
*** Could not find a suitably recent version of deal.II. ***
I also tested this locally with deal.II 9.6.1 using ASPECT_UNITY_BUILD=OFF, and the no-unity build passed.
Now that #6924 has been merged, is there anything else I should update in this PR?
As far as I understand, this PR is now limited to the serialization hooks for the dynamic core boundary temperature plugin (serialize(), save(), and load()), while the CoreData initialization issue has been handled separately in #6924.
I can rebase/retest this branch on current main if useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the old #6918 branch on top of current
mainand keeps the patch limited to the serialization hooks requested in review.The PR adds
serialize(),save(), andload()to the dynamic core boundary temperature plugin. It serializes the dynamic core state plus the small amount of runtime state needed for checkpoint/restart to restore the plugin object itself, including the OES data table when present. It does not add extra restart-path logic inupdate().Validation run locally:
git diff --checkcmake --build build-debug --target aspect -j20cmake --build build-debug-nounity --target aspect -j20dynamic_core: resumed run continues withDynamic core data updatedASPECT_SOURCE_DIR=/home/francyrad/Documenti/aspect_debug/aspect_pr_6918_work ctest --output-on-failure -R dynamic_core:dynamic_coreanddynamic_core_fully_solidpass;dynamic_core_fully_moltenonly differs in the last digit of two statistics time values on this machineRefs #6744. Follow-up to #6918.