Skip to content

Rename fastscape parameter#6965

Merged
gassmoeller merged 2 commits into
geodynamics:mainfrom
anne-glerum:rename_fastscape_output
May 21, 2026
Merged

Rename fastscape parameter#6965
gassmoeller merged 2 commits into
geodynamics:mainfrom
anne-glerum:rename_fastscape_output

Conversation

@anne-glerum
Copy link
Copy Markdown
Contributor

@anne-glerum anne-glerum commented May 5, 2026

This PR changes the name of an input parameter that describes the "transport coefficient" or "diffusivity" kd when selecting additional FastScape output. At the moment, it is called "deposition coefficient", which is actually the name of the parameter G, as also used in fastscape.cc, e.g.:

            bedrock_deposition_g = prm.get_double("Bedrock deposition coefficient");
            sediment_deposition_g = prm.get_double("Sediment deposition coefficient");

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Copy Markdown
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the renaming makes sense.

How long has this parameter been in the code? If it was added before the last release: Please add a changelog entry that describes the renaming. Ideally we would also include it in the list of updated parameters in our update script, see here, is this possible, or is it too confusing with the other deposition coefficient parameters?

@anne-glerum
Copy link
Copy Markdown
Contributor Author

The PR that introduced this parameter (#6504) was merged Jun 19, 2025, so after the latest release.

I'll try adding the renaming to the update script.

@anne-glerum
Copy link
Copy Markdown
Contributor Author

Renaming has been added to the update script.

Copy link
Copy Markdown
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@gassmoeller gassmoeller merged commit 4a8e80e into geodynamics:main May 21, 2026
9 checks passed
@anne-glerum anne-glerum deleted the rename_fastscape_output branch May 21, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants