Rename fastscape parameter#6965
Merged
gassmoeller merged 2 commits intoMay 21, 2026
Merged
Conversation
gassmoeller
reviewed
May 12, 2026
Member
gassmoeller
left a comment
There was a problem hiding this comment.
Code looks good and the renaming makes sense.
How long has this parameter been in the code? If it was added before the last release: Please add a changelog entry that describes the renaming. Ideally we would also include it in the list of updated parameters in our update script, see here, is this possible, or is it too confusing with the other deposition coefficient parameters?
Contributor
Author
|
The PR that introduced this parameter (#6504) was merged Jun 19, 2025, so after the latest release. I'll try adding the renaming to the update script. |
Contributor
Author
|
Renaming has been added to the update script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the name of an input parameter that describes the "transport coefficient" or "diffusivity"
kdwhen selecting additional FastScape output. At the moment, it is called "deposition coefficient", which is actually the name of the parameterG, as also used in fastscape.cc, e.g.:For all pull requests:
For new features/models or changes of existing features: