Skip to content

Conversation

@geofflamrock
Copy link
Owner

@geofflamrock geofflamrock commented Aug 19, 2025

Adds caching of GitHub pull requests to improve performance during updating a stack.

Details

The logic to update a stack got moved around in #328. A result of this is that we now get the status of a stack, including PRs multiple times, when syncing a stack (not updating) - once when we show the output and once to perform the update itself. This is to make the interface simpler for updating a stack.

I'm planning to change the way the underlying update works soon to not need to get a full status as we don't need the ahead/behind between branches to perform the update, we just need details like remote tracking branch and whether it exists, as well as the GitHub PR for cases when the remote branch doesn't get deleted. We'll probably still load the data multiple times but won't use the full status.

To avoid multiple requests to GitHub for pull requests, have added a caching implementation that decorates the inner one.

Background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants