Color ramp selector bugfixes: gradient cut off, missing label #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
mfisher87
changed the title
mfisher87
reviewed
Oct 17, 2025
packages/base/src/dialogs/symbology/components/color_ramp/CanvasSelectComponent.tsx
Outdated
Show resolved
Hide resolved
mfisher87
reviewed
Oct 17, 2025
packages/base/src/dialogs/symbology/components/color_ramp/ColorRampEntry.tsx
Outdated
Show resolved
Hide resolved
And simply the CSS just a touch Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>
gaolinai8888
pushed a commit
to gaolinai8888/jupytergis
that referenced
this pull request
Oct 24, 2025
…yter#950) Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com> Co-authored-by: Matt Fisher <mfisher87@gmail.com>
nakul-py
added a commit
to nakul-py/jupytergis
that referenced
this pull request
Nov 5, 2025
…yter#950) Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com> Co-authored-by: Matt Fisher <mfisher87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing Color Ramp cuts off bug and Adding name on Selected Ramp.
Screencast.From.2025-10-08.13-19-52.mp4
cc @mfisher87 and @martinRenou
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--950.org.readthedocs.build/en/950/
💡 JupyterLite preview: https://jupytergis--950.org.readthedocs.build/en/950/lite