Skip to content

feat(CanvasSaveButton): add extraData.qrCode option to insert QR code in canvas export #700

Merged
oterral merged 7 commits intomasterfrom
daniel/qrCode
Jan 9, 2023
Merged

feat(CanvasSaveButton): add extraData.qrCode option to insert QR code in canvas export #700
oterral merged 7 commits intomasterfrom
daniel/qrCode

Conversation

@danji90
Copy link
Copy Markdown
Contributor

@danji90 danji90 commented Dec 22, 2022 •
edited
Loading

How to

Add extraData option for a QR-code on the left side of canvas export

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@danji90 danji90 requested a review from oterral December 22, 2022 08:52
@danji90 danji90 self-assigned this Dec 22, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-spatial ✅ Ready (Inspect) Visit Preview Jan 2, 2023 at 11:54AM (UTC)

@danji90 danji90 changed the title QR code export feat(CanvasSaveButton): add extraData.qrCode option to insert QR code in canvas export Dec 22, 2022
@oterral oterral merged commit 16be889 into master Jan 9, 2023
@oterral oterral deleted the daniel/qrCode branch January 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oterral oterral oterral approved these changes

Assignees

@danji90 danji90

Labels

feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danji90 @oterral