Skip to content

fix: fix text style kml parsing as richt text#727

Merged
oterral merged 14 commits intomasterfrom
olivier/fixrichtext
Jul 11, 2024
Merged

fix: fix text style kml parsing as richt text#727
oterral merged 14 commits intomasterfrom
olivier/fixrichtext

Conversation

@oterral
Copy link
Copy Markdown
Contributor

@oterral oterral commented Jul 11, 2024

How to

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spatial ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:34pm

@oterral oterral changed the title fix: fix texyt style kml parsing as richt text fix: fix text style kml parsing as richt text Jul 11, 2024
@oterral oterral requested a review from danji90 July 11, 2024 08:41
@oterral oterral added the bug Something isn't working label Jul 11, 2024
Copy link
Copy Markdown
Contributor

@danji90 danji90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just correct the typos in the comments and clean plz

Comment thread src/utils/KML.js Outdated
Comment thread src/utils/KML.js Outdated
Comment thread src/utils/KML.js Outdated
@oterral oterral merged commit e5bc676 into master Jul 11, 2024
@oterral oterral deleted the olivier/fixrichtext branch July 11, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants