Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce .flake8 config file for convenient flake8 invoke #176

Closed
justb4 opened this issue Dec 7, 2017 · 2 comments

Comments

@justb4
Copy link
Member

commented Dec 7, 2017

flake8 is used within GHC for Python style checking via Travis. flake8 can however be somewhat cumbersome to use as a fully piped command line needs to be provided currently:

find . -name "*.py" | grep -v docs | grep -v migrations | xargs flake8

Also this takes all default flake8 settings. It is more convenient to use a .flake8 config file and later possibly in tox.ini. Now a developer and in Travis only this commandline remains for invoking flake8:

flake8

Also we can more clearly set some less stricter rules like the default 79 char line length.

@justb4 justb4 added the enhancement label Dec 7, 2017

@justb4 justb4 added this to the Version 0.3.0 milestone Dec 7, 2017

@justb4 justb4 self-assigned this Dec 7, 2017

justb4 added a commit that referenced this issue Dec 7, 2017

justb4 added a commit that referenced this issue Dec 7, 2017

#176 introduce .flake8 config file via PR #177
#176 introduce .flake8 config file and fix flake8 errs
@justb4

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2017

Done.

@justb4 justb4 closed this Dec 7, 2017

@justb4 justb4 reopened this Dec 7, 2017

justb4 added a commit that referenced this issue Dec 7, 2017

@justb4

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2017

Think this is done, closing. Open new issue when needed.

@justb4 justb4 closed this Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.